Add pr-workflow, coding, and general skills#42
Open
MajorLift wants to merge 6 commits into
Open
Conversation
…tributor-docs typescript.md / PR #74)
…ypescript.md / PR #74)
…hfully (inline eslint-disable, constraint-not-argument, prefer narrower)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds skills across three domains — the discipline of shipping a PR, TypeScript-specific coding practice, and general working habits.
Why for the extension: commit and review hygiene for a large, high-churn extension codebase; TypeScript patterns (
ts2589-workaround) for its deep generic types; andsimulator-controlto verify extension UI changes end-to-end. Cross-repo by nature, but each earns its place in day-to-day extension work.pr-workflow— the review-and-merge lifecyclecommit-discipline— logical-group, GPG-signed commits without conventional-commit noise.diff-audit— read your own diff before requesting review.pr-review-discipline— verify the mechanism before judging, triage before drafting, don't overcorrect, challenge workarounds.inline-comment-policy,epic-hierarchy,ticket-management.pr-descriptionintentionally omitted — the existingpr-workflow/pr-descriptionalready covers it.)coding— TypeScript practicets2589-workaround— resolve "type instantiation is excessively deep" via strict-flag patterns, type-level assertions, intermediate-defaulted type params, and cascade refactoring.simulator-control— drive iOS/Android simulators to verify UI changes (open the app, navigate, screenshot).derive-dont-define-types(derive from authoritative types; ad-hoc types duplicate, run too wide, and drift),avoid-any(anydisables type checking — substitute by position: assignee →unknown, assigned →never), plustype-level-assertions,typescript-strict-flag-pattern,typescript-intermediate-defaults,cascade-refactoring,spike-integration-boundaries.general— working habitsscope-lock— hold the agreed scope; don't let a task sprawl.specifications-as-guardrails— treat the spec as the boundary, not a suggestion.deploy-internal-vercel-app— deploy an internal Next.js app to the Consensys Vercel Enterprise account (Okta SSO).diagnose-blockers.CHANGELOG updated; commits GPG-signed.